Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackage.python-gitlab: add missing tests requirements #97866

Merged
merged 1 commit into from Sep 13, 2020
Merged

pythonPackage.python-gitlab: add missing tests requirements #97866

merged 1 commit into from Sep 13, 2020

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Sep 12, 2020 •
edited

Motivation for this change

#97479

Package not building because of missing test deêndencies

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

Result of nixpkgs-review pr 97866 1

2 packages built:
  • python37Packages.python-gitlab
  • python38Packages.python-gitlab

@mweinelt mweinelt merged commit 79ff0a1 into NixOS:master Sep 13, 2020
@nyanloutre nyanloutre deleted the python_gitlab_fix branch September 14, 2020 00:05
@nyanloutre nyanloutre mentioned this pull request Sep 14, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nyanloutre @mweinelt