Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fac-build: init at 0.5.3 #97868

Merged
merged 2 commits into from Sep 16, 2020
Merged

fac-build: init at 0.5.3 #97868

merged 2 commits into from Sep 16, 2020

Conversation

dpercy
Copy link

@dpercy dpercy commented Sep 12, 2020

Motivation for this change

Add fac build system: http://sites.science.oregonstate.edu/~roundyd/fac/

The Nix package name "fac" is taken, so does "fac-build" make sense instead?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
      (fac only supports Linux today.)
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk
danieldk suggested changes Sep 13, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution 👍

I have added some requested changes.

pkgs/development/tools/build-managers/fac/default.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/development/tools/build-managers/fac/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/build-managers/fac/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/build-managers/fac/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/build-managers/fac/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/build-managers/fac/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/build-managers/fac/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/build-managers/fac/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/build-managers/fac/default.nix Outdated Show resolved Hide resolved
@dpercy dpercy mentioned this pull request Sep 15, 2020
Closed
@dpercy
Copy link
Author

dpercy commented Sep 16, 2020

Thanks for the feedback! I think I've addressed everything so far.

danieldk
danieldk approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

Result of nixpkgs-review pr 97868 1

1 package built:
  • fac-build

@danieldk danieldk merged commit 917a183 into NixOS:master Sep 16, 2020
@dpercy
Copy link
Author

dpercy commented Sep 16, 2020

Thanks!

@dpercy dpercy deleted the fac-build branch September 16, 2020 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dpercy @danieldk @Janik-Haag