doesn't mean much if we can't enforce this rule via ofborg. Also some of these descriptions are generated so we would need to fix those descriptions as well. Not worth the hassle IMO.

We can put this in ofborg (see #97685), but for now, it would be good to fix up the description of hundreds of packages.

I'll remove the edits to the autogenerated packages.

@worldofpeace Should I resolve the merge conflicts and have this be merged? The plan is for @GrahamcOfBorg to check this for new PRs in the future.

Sure, let's try to merge it quickly to avoid any more conflicts.

@worldofpeace Should I resolve the merge conflicts and have this be merged? The plan is for @GrahamcOfBorg to check this for new PRs in the future.

I think we're actually considering moving everything into github checks.

I think we're actually considering moving everything into github checks.

I'm okay with this, scales much better; and don't have to bug graham all the time

For future reference,

let
  pkgs = import ./../../default.nix {};

  safeEval = e: let result = builtins.tryEval e;
                in
                  if result.success
                  then result.value
                  else [ ];

  packagesWith = cond:
    pkgs.lib.concatLists (pkgs.lib.mapAttrsToList
      (name: pkg: safeEval
        (if pkgs.lib.isDerivation pkg && cond name pkg
         then [ (builtins.elemAt (pkgs.lib.splitString ":" pkg.meta.position) 0) ]
         else [ ]))
      pkgs);

  hasDesc = pkg: builtins.hasAttr "description" pkg.meta;
  lastChar = x: builtins.substring (builtins.stringLength x - 1) (-1) x;
  report = desc: l:
    builtins.trace (pkgs.lib.concatStringsSep "\n" l) "";
in
{
  periodDesc =
    report "have a period at the end of their description"
      (packagesWith
        (name: pkg:
          if hasDesc pkg && builtins.stringLength pkg.meta.description != 0
          then lastChar pkg.meta.description == "."
          else false));
}

The output of the script is fed into an awk file with contents

{ system("sed --in-place='' -re 's#(description\\s*=\\s*\".+)\\.\"#\\1\"#' " $0)}

Finally, I went through the changed files to see which ones had a delta greater than 2, indicating it was probably a package collection (Haskell/Node/Lua packages came up).

@jonringer @worldofpeace Should be ready to merge.