Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libndtypes, libxnd, libgumath: unstable-2018-11-27 -> unstable-2019-08-01, to fix gumath python package & darwin #97837

Merged
merged 3 commits into from Sep 20, 2020
Merged

libndtypes, libxnd, libgumath: unstable-2018-11-27 -> unstable-2019-08-01, to fix gumath python package & darwin #97837

merged 3 commits into from Sep 20, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 12, 2020 •
edited

Motivation for this change

ZHF: #97479

This was really all just to fix pythonPackages.gumath. It seems it really just needed updating to cope with a newer numpy api. But ndtypes, xnd, and gumath all seem to come as an interrelated group of packages (and none of them seem to believe in actual named releases), so I bumped all of them to the last commit in each's master branch (this was around 2019-08-01 for all of them), hoping this would mean they're all intended to work together. Luckily none of them have any reverse dependencies outside their little clique, so this should be appropriate for inclusion in release-20.09.

Required some extended darwin tinkering to get the python packages to work there.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
libndtypes, pythonPackages.ndtypes: unstable-2018-11-27 -> unstable-2…
be94b14 
…019-08-01

this is the most recent commit to upstream's master at time of writing

includes fixes of python package for darwin
@risicle
libxnd, pythonPackages.xnd: unstable-2018-11-27 -> unstable-2019-08-01
73a4ce8 
this is the most recent commit to upstream's master at time of writing

includes fixes of python package for darwin
@risicle
libgumath, pythonPackages.gumath: unstable-2018-11-27 -> unstable-201…
69bf3ca 
…9-08-01

this is the most recent commit to upstream's master at time of writing

includes fixes of python package for darwin
@risicle risicle changed the title libndtypes, libxnd, libgumath: unstable-2018-11-27 -> unstable-2019-08-01, fix gumath python package & darwin libndtypes, libxnd, libgumath: unstable-2018-11-27 -> unstable-2019-08-01, to fix gumath python package & darwin Sep 12, 2020
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels Sep 12, 2020
@ofborg ofborg bot requested a review from costrouc September 12, 2020 13:14
@risicle
Copy link
Contributor Author

risicle commented Sep 12, 2020

@ofborg build python37Packages.ndtypes python37Packages.xnd python37Packages.gumath

jonringer
jonringer approved these changes Sep 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/97837
9 packages built:
libgumath libndtypes libxnd python37Packages.gumath python37Packages.ndtypes python37Packages.xnd python38Packages.gumath python38Packages.ndtypes python38Packages.xnd

@jonringer jonringer merged commit eb86bff into NixOS:master Sep 20, 2020
@risicle risicle mentioned this pull request Sep 20, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @jonringer