Fix: don't log every time a server is not responding #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens often enough in production that it blurs the logs from what is really going wrong. It turns out a lot of people have their advertisement on, but they never really advertise. This is most likely due to their firewall not allowing all required traffic for a gameserver to be advertised.
frosch123
approved these changes
Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens often enough in production that it blurs the logs
from what is really going wrong. It turns out a lot of people
have their advertisement on, but they never really advertise.
This is most likely due to their firewall not allowing all
required traffic for a gameserver to be advertised.