Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] nixos/jitsi-meet: add docs #97863

Merged
merged 1 commit into from Sep 13, 2020
Merged

[20.09] nixos/jitsi-meet: add docs #97863

merged 1 commit into from Sep 13, 2020

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented Sep 12, 2020

(cherry picked from commit 531c08a)

Motivation for this change

Jitsi Meet is a newly added module, so it needs to be in the release notes and needed documentation.

cc @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
nixos/jitsi-meet: add docs
0ca464e 
(cherry picked from commit 531c08a)
@ryantm ryantm added this to the 20.09 milestone Sep 12, 2020
@ryantm ryantm changed the title nixos/jitsi-meet: add docs [20.09] nixos/jitsi-meet: add docs Sep 12, 2020
@jonringer
Copy link
Contributor

it should also be listed that there was an added module, but that's a far cry from this, thanks! :)

jonringer
jonringer approved these changes Sep 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manual still builds :)

@jonringer jonringer merged commit df2a179 into NixOS:release-20.09 Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryantm @jonringer