Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: drop protobuf override #97870

Merged
merged 1 commit into from Sep 12, 2020
Merged

home-assistant: drop protobuf override #97870

merged 1 commit into from Sep 12, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Sep 12, 2020 •
edited

Motivation for this change

The aioesphome library was updated in d49fc36 and that requires a newer protobuf version. So let's drop the override in home-assistant.

Requirement already satisfied: zeroconf<1.0,>=0.28.0 in /nix/store/5m4yrsfh12pfz07p2c4jdx7j27bv5j0z-python3.8-zeroconf-0.28.2/lib/python3.8/site-packages (from aioesphomeapi==2.6.3) (0.28.2)
ERROR: Could not find a version that satisfies the requirement protobuf<4.0,>=3.12.2 (from aioesphomeapi==2.6.3) (from versions: none)
ERROR: No matching distribution found for protobuf<4.0,>=3.12.2 (from aioesphomeapi==2.6.3)

Untested

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
home-assistant: drop protobuf override
68c4099 
aioesphome was updated to 2.6.3 which requires protobuf>=3.12.2,<4.0.
@mweinelt mweinelt added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 12, 2020
@mweinelt
Copy link
Member Author

Buildtested using nix-build -E "with import ./. {}; home-assistant.override { extraPackages = ps: [ ps.aioesphomeapi ]; }".

@mweinelt
Copy link
Member Author

Tested on my home setup against 20.09 and wfm.

@mweinelt mweinelt merged commit d5a689e into NixOS:master Sep 12, 2020
@mweinelt mweinelt mentioned this pull request Sep 13, 2020
Merged
10 tasks
@mweinelt mweinelt deleted the hass branch September 13, 2020 00:54
@mweinelt mweinelt mentioned this pull request Sep 13, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mweinelt