Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] ytree: fix build #97854

Merged
merged 1 commit into from Sep 12, 2020
Merged

[20.09] ytree: fix build #97854

merged 1 commit into from Sep 12, 2020

Conversation

wkral
Copy link
Contributor

@wkral wkral commented Sep 12, 2020

(cherry picked from commit 0a10ec4)

Motivation for this change

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wkral
ytree: fix build
db7c226 
(cherry picked from commit 0a10ec4)
@wkral wkral changed the title ytree: fix build [20.09] ytree: fix build Sep 12, 2020
@AndersonTorres
Copy link
Member

Just to know, where are the error messages? I am a bit curious because I needed to do some hackings before.

@AndersonTorres AndersonTorres merged commit 063598c into NixOS:release-20.09 Sep 12, 2020
@wkral
Copy link
Contributor Author

wkral commented Sep 13, 2020 •
edited

@AndersonTorres I'm not totally clear on you question but I orignally found that the build was broken through the hydra logs, for example: https://hydra.nixos.org/build/126813125/nixlog/1

@wkral wkral deleted the backport-ytree-fix branch September 14, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wkral @AndersonTorres