Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.gssapi: fix tests, 1.6.2 -> 1.6.9 #97873

Merged
merged 2 commits into from Sep 23, 2020
Merged

pythonPackages.gssapi: fix tests, 1.6.2 -> 1.6.9 #97873

merged 2 commits into from Sep 23, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 13, 2020

Motivation for this change

ZHF: #97479

The failing tests seem to be causing trouble upstream too (pythongssapi/python-gssapi#220), so I skipped them (which itself wasn't particularly simple thanks to nosetests).

Also bumped to latest version, mostly to get python 3.8 working. Though this does have the effect of dropping python 2.7 support 馃し

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

should also remove shouldbe from the dependencies, or else that failure will propagate to gssapi:

builder for '/nix/store/pv86mnsxhjr3mz3kanlffl3dwdyg3z0m-python3.8-shouldbe-0.1.2.drv' failed with exit code 1; last 10 log lines:
      from should_be import core
    File "/build/shouldbe-0.1.2/should_be/core.py", line 264, in <module>
      class ObjectMixin(BaseMixin):
    File "/build/shouldbe-0.1.2/should_be/core.py", line 334, in ObjectMixin
      alias_method('should_be_true', should_be_truthy)
    File "/build/shouldbe-0.1.2/should_be/core.py", line 169, in alias_method
      new_code = buildCode(oc, name=new_name)
    File "/build/shouldbe-0.1.2/should_be/core.py", line 136, in buildCode
      resc = CodeType(argcount or baseCode.co_argcount,
  TypeError: an integer is required (got type bytes)
cannot build derivation '/nix/store/aj7nhajw0pzq6lmm7jqrskqs7awy23vq-python3.8-gssapi-1.6.9.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/jgas3kylvs2pghwqqwbv8q6q1jd86wrx-python3.8-asyncssh-2.3.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/2r0ckwfa46zi8q0ig30mp22yf9hwg136-env.drv': 2 dependencies couldn't be built
[3 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/2r0ckwfa46zi8q0ig30mp22yf9hwg136-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/97873
2 packages failed to build:
python38Packages.asyncssh python38Packages.gssapi

2 packages built:
python37Packages.asyncssh python37Packages.gssapi

@jonringer
Copy link
Contributor

also related: pythongssapi/python-gssapi#215

@risicle
pythonPackages.gssapi: fix tests
9d60529 
the failing tests appear to also be causing trouble upstream
@risicle
pythonPackages.gssapi: 1.6.2 -> 1.6.9
f56a8ba
@risicle
Copy link
Contributor Author

risicle commented Sep 20, 2020 •
edited

Well ok, suppose that just means I've got to disable the tests for python 3.8 then - shouldbe is used heavily. At least there's pythonImportsCheck.

On that note, it would be pretty useful to be able to introspect into packages to see if they're "disabled", allowing us to switch on that condition rather than replicate the logic of "shouldbe doesn't work on python 3.8" here.

@jonringer
Copy link
Contributor

Well ok, suppose that just means I've got to disable the tests for python 3.8 then

Yea, that seems fine

On that note, it would be pretty useful to be able to introspect into packages to see if they're "disabled", allowing us to switch on that condition rather than replicate the logic of "shouldbe doesn't work on python 3.8" here.

The problem is that "disabling" a package just correlates to throwing an error. And this is kind of an "exceptional" problem, as most upstreams aren't completely dead.

It's unfortunate that upstream invested so much in an upstream library.

jonringer
jonringer approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 97873 1

2 packages failed to build:
  • python38Packages.asyncssh
  • python38Packages.gssapi
2 packages built:
  • python37Packages.asyncssh
  • python37Packages.gssapi

@jonringer jonringer merged commit 9a47216 into NixOS:master Sep 23, 2020
@jonringer
Copy link
Contributor

not sure why report was wrong:

https://github.com/NixOS/nixpkgs/pull/97873
4 packages built:
python37Packages.asyncssh python37Packages.gssapi python38Packages.asyncssh python38Packages.gssapi

@risicle risicle mentioned this pull request Sep 23, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @jonringer