Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: support SOCKS proxy for new outgoing connections #7

Merged
merged 1 commit into from Sep 12, 2020

Conversation

TrueBrain
Copy link
Member

In the way we currently deploy this in production, it runs on
AWS ECS which does not support IPv6 for containers. As we query
game servers from the container, a new outgoing connection has
to be created which supports both IPv4 and IPv6. By using a SOCKS
proxy deployed within the AWS VPC, we can now query game servers
from within the container without AWS ECS supporting IPv6.

Of course as soon as AWS supports IPv6 for AWS ECS this can be
dropped.

LordAro
LordAro previously approved these changes Sep 12, 2020
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine

In the way we currently deploy this in production, it runs on
AWS ECS which does not support IPv6 for containers. As we query
game servers from the container, a new outgoing connection has
to be created which supports both IPv4 and IPv6. By using a SOCKS
proxy deployed within the AWS VPC, we can now query game servers
from within the container without AWS ECS supporting IPv6.

Of course as soon as AWS supports IPv6 for AWS ECS this can be
dropped.
@TrueBrain TrueBrain merged commit ff2477c into OpenTTD:master Sep 12, 2020
@TrueBrain TrueBrain deleted the socks_proxy branch September 12, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants