Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] acme-client: build with gcc #97858

Merged
merged 1 commit into from Sep 13, 2020

Conversation

treed
Copy link
Contributor

@treed treed commented Sep 12, 2020

acme-client fails to build with clang, which breaks the build on darwin.

(cherry picked from commit e45ddae)

Motivation for this change

Backport of #97734

ZHF: #97479

cc @NixOS/nix-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

acme-client fails to build with clang, which breaks the build on darwin.

(cherry picked from commit e45ddae)
@treed treed changed the title acme-client: build with gcc [20.09] acme-client: build with gcc Sep 12, 2020
@risicle
Copy link
Contributor

risicle commented Sep 13, 2020

WFM macos 10.14

@risicle risicle merged commit 562672a into NixOS:release-20.09 Sep 13, 2020
@treed treed deleted the backport-acme-client-zhf branch September 15, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants