Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

carla: 2.1.1 -> 2.2.0-RC2 #97834

Closed
wants to merge 2 commits into from
Closed

carla: 2.1.1 -> 2.2.0-RC2 #97834

wants to merge 2 commits into from

Conversation

suhr
Copy link
Contributor

@suhr suhr commented Sep 12, 2020

Motivation for this change

Though this is a release candidate, it has an essential feature: VST3 support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

doronbehar
doronbehar reviewed Sep 12, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't merge this until it's 2.2.0 is fully released, but it's OK to get ready for it and enjoying it from your branch of Nixpkgs :).

pkgs/applications/audio/carla/default.nix Outdated Show resolved Hide resolved
@doronbehar
Copy link
Contributor

Also note the aarch builds fail.

@suhr @doronbehar
Update pkgs/applications/audio/carla/default.nix
a1a52ab 
Co-authored-by: Doron Behar <doron.behar@gmail.com>
@SuperSandro2000
Copy link
Member

@suhr please resolve the merge conflict.

@suhr
Copy link
Contributor Author

suhr commented Jan 18, 2021

Nixpkgs already contains Carla 2.2.0.

@suhr suhr closed this Jan 18, 2021
@suhr suhr deleted the carla branch January 18, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar left review comments

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@suhr @doronbehar @SuperSandro2000