Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tor-browser-bundle-bin: 9.5.3 -> 9.5.4 #96436

Merged
merged 1 commit into from Aug 28, 2020
Merged

tor-browser-bundle-bin: 9.5.3 -> 9.5.4 #96436

merged 1 commit into from Aug 28, 2020

Conversation

TethysSvensson
Copy link
Contributor

@TethysSvensson TethysSvensson commented Aug 27, 2020 •
edited

Motivation for this change

New version upstream, includes security updates.

See the tor blog for general information and the firefox advisory for information specific to the security fixes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

@ofborg test tor

jonringer
jonringer approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launches fine
tests pass

https://github.com/NixOS/nixpkgs/pull/96436
1 package built:
torbrowser

@jonringer jonringer merged commit 14d8030 into NixOS:master Aug 28, 2020
@TethysSvensson TethysSvensson deleted the tor-browser-954 branch August 29, 2020 07:17
@TethysSvensson TethysSvensson mentioned this pull request Aug 29, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TethysSvensson @jonringer