Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: amaranth-lang/amaranth
base: ef7a3bcfb1aa
Choose a base ref
...
head repository: amaranth-lang/amaranth
compare: 5b01499901d4
Choose a head ref
  • 2 commits
  • 34 files changed
  • 1 contributor

Commits on Aug 27, 2020

  1. tests: move out of the main package.

    Compared to tests in the repository root, tests in the package have
    many downsides:
      * Unless explicitly excluded in find_packages(), tests and their
        support code effectively become a part of public API.
        This, unfortunately, happened with FHDLTestCase, which was never
        intended for downstream use.
      * Even if explicitly excluded from the setuptools package, using
        an editable install, or setting PYTHONPATH still allows accessing
        the tests.
      * Having a sub-package that is present in the source tree but not
        exported (or, worse, exported only sometimes) is confusing.
      * The name `nmigen.test` cannot be used for anything else, such as
        testing utilities that *are* intended for downstream use.
    whitequark committed Aug 27, 2020
    1
    Copy the full SHA
    67b957d View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    5b01499 View commit details
    Browse the repository at this point in the history