nixos/stunnel: Options for client certificates #96401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't this put the client's private key into the nix store? |
…ix store
With type.path, both of these usages are permitted:
key = ./foo-client-key.pem; # Bad! Puts secret in store.
key = "/var/lib/foo/client-key.pem"; # OK
Disallow the bad usage using types.strMatching "/.*" instead of types.path.
The server version of this probably ought to be changed also, but that
would be a breaking change. We can change the client key type because
this commit and the commit that introduces the client key option are
in the same PR and will be merged atomically. We keep this a separate
commit to provide a succinct concrete example of the problems described
in NixOS#24288 .
Good point. It does if you use a path: Experienced Nix users will know to use a path-in-a-string to avoid this problem, but you're right: There's no reason to leave this sharp edge here. I changed Thanks. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
13 tasks
|
Superseded by PR #152065. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Don't stand in the way of folks trying to use this stunnel feature. (This module has no extraConfig option that would otherwise allow this through.)
Things done
sandboxinnix.confon non-NixOS linux)