Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] chromium: 84.0.4147.135 -> 85.0.4183.83 #96457

Merged
merged 2 commits into from Aug 28, 2020
Merged

[20.03] chromium: 84.0.4147.135 -> 85.0.4183.83 #96457

merged 2 commits into from Aug 28, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Aug 27, 2020 •
edited

Motivation for this change

Backport of #96308.

Testing status
platform attribute status tester
x86_64 chromium ✔️ @Frostman
x86_64 nixosTests.chromium ✔️ @Frostman
x86_64 google-chrome - -
aarch64 chromium - -
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
chromium: 84.0.4147.135 -> 85.0.4183.83
9f966ba 
https://chromereleases.googleblog.com/2020/08/stable-channel-update-for-desktop_25.html

This update includes 20 security fixes.

CVEs:
CVE-2020-6558 CVE-2020-6559 CVE-2020-6560 CVE-2020-6561 CVE-2020-6562
CVE-2020-6563 CVE-2020-6564 CVE-2020-6565 CVE-2020-6566 CVE-2020-6567
CVE-2020-6568 CVE-2020-6569 CVE-2020-6570 CVE-2020-6571

(cherry picked from commit 4252ba9)
@primeos
chromium: Make the gnChromium overrides depend on the version
4737bed 
This is more robust than depending on the channel, though the version
should only matter if the configuration phase fails.
This also switches to the intended version for `chromium` which should
be higher since M85 is in the stable channel.

Thanks `@volth` for pointing this out.

(cherry picked from commit 25aed42)
@Frostman
Copy link
Member

nixosTests.chromium passed ok (x86_64)

@primeos primeos merged commit 3182792 into NixOS:release-20.03 Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thefloweringash thefloweringash Awaiting requested review from thefloweringash

@bendlas bendlas Awaiting requested review from bendlas

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@primeos @Frostman