Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

katago: 1.6.0 -> 1.6.1 #96384

Merged
merged 1 commit into from Aug 28, 2020
Merged

katago: 1.6.0 -> 1.6.1 #96384

merged 1 commit into from Aug 28, 2020

Conversation

OmnipotentEntity
Copy link
Contributor

Motivation for this change

This version fixes a memory usage problem with the Eigen backend. It also adds a CMake switch for bigger board support. So I exposed it in the derivation as well under the option bigBoardEnabled, it is not enabled by default.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@OmnipotentEntity
Copy link
Contributor Author

Sorry for the back to back updates. I didn't expect another quick point release.

rnhmjoj
rnhmjoj reviewed Aug 28, 2020
View reviewed changes
pkgs/games/katago/default.nix Outdated
@@ -17,7 +17,8 @@
, gpuEnabled ? true
, useAVX2 ? false
, cudaSupport ? false
, useTcmalloc ? true}:
, useTcmalloc ? true
, bigBoardEnabled ? false}:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't notice before... but these options are usually named enableSomething. Can you rename this and gpuEnabled as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easier done than said.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@rnhmjoj rnhmjoj merged commit a8b95d8 into NixOS:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OmnipotentEntity @rnhmjoj