Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texstudio: 2.12.22 -> 3.0.0 #96462

Merged
merged 1 commit into from Sep 1, 2020
Merged

texstudio: 2.12.22 -> 3.0.0 #96462

merged 1 commit into from Sep 1, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Aug 27, 2020

Motivation for this change

Upstream release.

This release drops qt4 support, but we haven't been using that for >2 years anyways.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124
texstudio: 2.12.22 -> 3.0.0
e56f55f 
this release drops qt4 support, but we haven't been using that for >2 years anyways
@ofborg ofborg bot requested a review from Chaddai August 27, 2020 13:00
veprbl
veprbl approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on x86_64-linux (NixOS)

@ajs124 ajs124 requested a review from Lassulus August 31, 2020 21:38
@Lassulus Lassulus merged commit f5d9a1d into NixOS:master Sep 1, 2020
@ajs124 ajs124 deleted the upd/texstudio branch September 2, 2020 00:08
@ajs124
Copy link
Member Author

ajs124 commented Sep 2, 2020

Perfect timing, they just released 3.0.1 🤦

@veprbl
Copy link
Member

veprbl commented Sep 2, 2020

@ajs124 No worries, open a new PR. Thank you for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@Chaddai Chaddai Awaiting requested review from Chaddai

@Lassulus Lassulus Awaiting requested review from Lassulus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @veprbl @Lassulus