ocamlPackages.elpi: 1.11.2 -> 1.11.4 #96463
Conversation
|
@GrahamcOfBorg build ocamlPackages.elpi coqPackages_8_11.coq-elpi coqPackages_8_12.coq-elpi coqPackages_8_11.hierarchy-builder coqPackages_8_12.hierarchy-builder |
|
|
||
| propagatedBuildInputs = [ camlp5 ppx_deriving re ]; | ||
| propagatedBuildInputs = [ ncurses camlp5 ppx_deriving re ]; |
There was a problem hiding this comment.
According to @gares if I understood well elpi may need tput at runtime to display outputs in some context, and ncurses was the most sensible derivation exposing it... would some other changes make more sense?
There was a problem hiding this comment.
propagatedBuildInputs is not for runtime dependencies. You may either wrap the elpi binaries to set the PATH environment variable or hardcode the path to tput in the source code.
There was a problem hiding this comment.
@vbgl thanks! I do not know how to implement either of these solutions, can you give me some doc and/or examples?
There was a problem hiding this comment.
For instance, the opam binary is wrapped: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/ocaml/opam/default.nix#L104
Coq hardcodes the path to csdp: https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/science/logic/coq/default.nix#L44
A third possibility is just to leave a comment: “elpi will assume your terminal is 80 positions wide, unless tput is found in PATH”.
There was a problem hiding this comment.
@vbgl, thanks a lot for you advice, I took the option to hardcode the path and it works well, thank you!
There was a problem hiding this comment.
You’re welcome. Thanks for your contributions.
|
@GrahamcOfBorg build ocamlPackages.elpi coqPackages_8_11.coq-elpi coqPackages_8_12.coq-elpi coqPackages_8_11.hierarchy-builder coqPackages_8_12.hierarchy-builder |
and fixing dependencies
|
@GrahamcOfBorg build coqPackages_8_11.hierarchy-builder coqPackages_8_12.hierarchy-builder |
|
Thanks! |
and fixing dependencies
Motivation for this change
Upgrading elpi and coq-elpi
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)