Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tippecanoe: 1.35.0 -> 1.36.0 #96409

Merged
merged 1 commit into from Sep 6, 2020
Merged

tippecanoe: 1.35.0 -> 1.36.0 #96409

merged 1 commit into from Sep 6, 2020

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Aug 26, 2020

Motivation for this change

Changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Aug 31, 2020

WFM on macos 10.14. Wondering what the aarch64 failure is about though.

tests/coalesce-tract/out/-P_--coalesce_--reorder_-z11_-Z11_-y_STATEFP10_-y_COUNTYFP10_-l_merged.json.check.out tests/coalesce-tract/out/-P_--coalesce_--reorder_-z11_-Z11_-y_STATEFP10_-y_COUNTYFP10_-l_merged.json differ: char 5105, line 34
make: *** [Makefile:94: tests/coalesce-tract/out/-P_--coalesce_--reorder_-z11_-Z11_-y_STATEFP10_-y_COUNTYFP10_-l_merged.json.check] Error 1
make: *** Waiting for unfinished jobs....

@ofborg build tippecanoe

@risicle
Copy link
Contributor

risicle commented Sep 2, 2020

Yup, seems to persist.

@sikmir
Copy link
Member Author

sikmir commented Sep 6, 2020

I have no idea what is going wrong on aarch64... What is better way to proceed? Mark as not supported on aarch64?

@risicle
Copy link
Contributor

risicle commented Sep 6, 2020

Sad, but I guess it's the best thing to do. Might be worth opening a ticket upstream letting them know that their coalesce-tract test may have issues on non-x86.

It doesn't help that:

  1. They appear to be doing bytewise comparisons of json output, which will obviously be unnecessarily sensitive to e.g. object key order.
  2. We only have access to ofborg for aarch64, and can't inspect its filesystem after failure.

@sikmir
Copy link
Member Author

sikmir commented Sep 6, 2020

Sad, but I guess it's the best thing to do. Might be worth opening a ticket upstream letting them know that their coalesce-tract test may have issues on non-x86.

@risicle risicle merged commit 24e513b into NixOS:master Sep 6, 2020
@sikmir sikmir deleted the tippecanoe branch September 6, 2020 19:14
@sikmir
Copy link
Member Author

sikmir commented Nov 25, 2021

@risicle I've just tried to build tippecanoe on my aarch64 machine and it works just fine. Can we unbroke it on aarch64 and perhaps disable this test on aarch64 to not fail on CI?

@risicle
Copy link
Contributor

risicle commented Nov 25, 2021

Having worked a bit more with aarch64 packages now, there are quite a few which have slight disagreements in float precision with "expected" results that were presumably generated on x86. I think this is due to the existence of the x87 80bit extended precision mode.

Short answer: yes, but I would raise the issue upstream too if it isn't already.

@sikmir
Copy link
Member Author

sikmir commented Nov 25, 2021

Short answer: yes, but I would raise the issue upstream too if it isn't already.

Here is upstream issue: mapbox/tippecanoe#881.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants