Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for case where candidate arrives before SLD(answer) #25257

Merged
merged 1 commit into from Sep 15, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Aug 27, 2020

The bug it's checking for manifests as random timeouts on WPT tests
that use RTCPeerConnection-helper's functions to set up connection.

The bug was fixed in another CL, but these tests exercise interesting
functionality, so worth adding.

The purpose of the helper-test is to ensure that if we introduce more
instabilities by changes to the helper, this test should fail first.

Bug: chromium:1122106
Change-Id: Ic59f76fd36f645cee0e08d6dcd69db0c62cbc903
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379193
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806914}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

The bug it's checking for manifests as random timeouts on WPT tests
that use RTCPeerConnection-helper's functions to set up connection.

The bug was fixed in another CL, but these tests exercise interesting
functionality, so worth adding.

The purpose of the helper-test is to ensure that if we introduce more
instabilities by changes to the helper, this test should fail first.

Bug: chromium:1122106
Change-Id: Ic59f76fd36f645cee0e08d6dcd69db0c62cbc903
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379193
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806914}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants