python.pkgs.graphviz: 0.10.1 -> 0.14.1 #96451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewrisinger
suggested changes
Aug 27, 2020
There was a problem hiding this comment.
Few suggested changes while upgrading:
- add
meta.changelog - switch to
pytestCheckHookinstead ofpytest: https://github.com/NixOS/nixpkgs/blob/6770ab0771703b573a0a1c1f6c238352bebc9c31/doc/languages-frameworks/python.section.md#using-pytestcheckhook - (Maybe??) remove
mockin favor ofpytest-mock, I assumepytest-mockcontainsmockbut not sure.
Built the pythonPackages.graphviz packages with nix-review, not going to build/download all 200+ packages .
jonringer
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
diff LGTM
failures are broken on master, and look unrelated
https://github.com/NixOS/nixpkgs/pull/96451
10 packages failed to build:
bareos beets python37Packages.dask-xgboost python37Packages.ibis-framework python37Packages.optuna python37Packages.pyro-ppl python37Packages.xgboost python38Packages.dask-xgboost python38Packages.pyro-ppl python38Packages.xgboost
42 packages built:
ceph ceph-client flexget libceph mnemosyne python27Packages.graphviz python27Packages.mxnet python27Packages.objgraph python27Packages.prov python27Packages.pydotplus python37Packages.cherrypy python37Packages.graphviz python37Packages.heudiconv python37Packages.mxnet python37Packages.nipype python37Packages.objgraph python37Packages.prov python37Packages.pyalgotrade python37Packages.pydotplus python37Packages.pysonos python37Packages.soco python37Packages.streamz python37Packages.ws4py python37Packages.xdot python37Packages.zerobin python38Packages.cherrypy python38Packages.graphviz python38Packages.mxnet python38Packages.nipype python38Packages.objgraph python38Packages.prov python38Packages.pyalgotrade python38Packages.pydotplus python38Packages.pysonos python38Packages.soco python38Packages.streamz python38Packages.ws4py python38Packages.xdot python38Packages.zerobin sabnzbd sambaFull tribler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)