modem-manager-gui: 0.0.19.1 -> 0.0.20 #96418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worldofpeace
changed the title
Galagora
force-pushed
the
update-modem-manager-gui
branch
2 times, most recently
from
8b1ee90
to
7f20908
Compare
worldofpeace
suggested changes
Aug 27, 2020
There was a problem hiding this comment.
I'm seeing this uses libappindicator-gtk3 which is dead. see #96420. I did confirm in the changelog that it supports it http://hg.code.sf.net/p/modem-manager-gui/code/file/tip/Changelog#l5
Galagora
force-pushed
the
update-modem-manager-gui
branch
from
7f20908
to
88e2b57
Compare
|
OK, it works as far as I can see. |
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Galagora
force-pushed
the
update-modem-manager-gui
branch
from
6efc41d
to
430c5b8
Compare
Galagora
force-pushed
the
update-modem-manager-gui
branch
from
430c5b8
to
3eb022c
Compare
Upstream source is on Sourceforge, but that's HTTP-only.
Included in current release
Galagora
force-pushed
the
update-modem-manager-gui
branch
from
3eb022c
to
1b1f3ff
Compare
|
About the ofono drop 0ae487e#diff-d63e10da780ee77c1f16e36d5a02ce17, is that not required to build a plugin for it in this project? |
libappindicator-gtk3 is unmaintained, should be replaced with fork (see NixOS#96420)
Galagora
force-pushed
the
update-modem-manager-gui
branch
from
1b1f3ff
to
22e9ad4
Compare
|
Yeah, I see, unlike ModemManager, oFono isn't installed independently of programs. |
|
Hey, @worldofpeace, this should be good, right? Your requested changes are still pending because I force pushed and can't resolve them, but I changed the lib. |
|
thx @Galagora ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #96417.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)