gnum4: include fix without fetchurl, update comment #96382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnum4 is build in the nixos installer test, which is done on a machine without internet access. Using fetchurl for patches results in the following error: machine # building '/nix/store/7x9q5qdd27aljvvrnrvabb6h6b0sh082-01-fix-ftbfs-with-glibc-2.28.patch.drv'... machine # warning: unable to download 'https://sources.debian.org/data/main/m/m4/1.4.18-2/debian/patches/01-fix-ftbfs-with-glibc-2.28.patch': Couldn't resolve host name (6); retrying in 323 ms machine # warning: unable to download 'https://sources.debian.org/data/main/m/m4/1.4.18-2/debian/patches/01-fix-ftbfs-with-glibc-2.28.patch': Couldn't resolve host name (6); retrying in 575 ms machine # warning: unable to download 'https://sources.debian.org/data/main/m/m4/1.4.18-2/debian/patches/01-fix-ftbfs-with-glibc-2.28.patch': Couldn't resolve host name (6); retrying in 1109 ms machine # warning: unable to download 'https://sources.debian.org/data/main/m/m4/1.4.18-2/debian/patches/01-fix-ftbfs-with-glibc-2.28.patch': Couldn't resolve host name (6); retrying in 2442 ms machine # error: unable to download 'https://sources.debian.org/data/main/m/m4/1.4.18-2/debian/patches/01-fix-ftbfs-with-glibc-2.28.patch': Couldn't resolve host name (6) machine # builder for '/nix/store/7x9q5qdd27aljvvrnrvabb6h6b0sh082-01-fix-ftbfs-with-glibc-2.28.patch.drv' failed with exit code 1 Add the patch to nixpkgs and update the comment on the patches parameter to indicate that fetchurl and similar helpers will break the test. Fixes NixOS#96361
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Gnum4 is build in the nixos installer test, which is done on a machine
without internet access. Using fetchurl for patches results in the
following error:
Add the patch to nixpkgs and update the comment on the patches parameter
to indicate that fetchurl and similar helpers will break the test.
Fixes #96361
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)