Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox-beta-bin: 80.0b8 -> 81.0b4 #96447

Merged
merged 1 commit into from Sep 1, 2020
Merged

firefox-beta-bin: 80.0b8 -> 81.0b4 #96447

merged 1 commit into from Sep 1, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Aug 27, 2020

Motivation for this change

While I try to sort out making nixpkgs-mozilla pure enough to be used from a flake (utilizing https://github.com/colemickens/flake-firefox-nightly), I'd like to be mostly up-to-date. (I use Firefox Beta because sometimes Nightly breaks some interactions with Reddit + RES, whereas this breakage doesn't appear to make it into the beta.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Closes #96284.

@Atemu Atemu mentioned this pull request Aug 27, 2020
Closed
10 tasks
Atemu
Atemu approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 96447 1

1 package built:
- firefox-beta-bin-unwrapped

WOMM.

@cole-h cole-h changed the title firefox-beta-bin: 80.0b8 -> 81.0b2 firefox-beta-bin: 80.0b8 -> 81.0b3 Aug 28, 2020
@cole-h
Copy link
Member Author

cole-h commented Aug 28, 2020

Updated to 81.0b3.

@cole-h cole-h requested a review from Atemu August 28, 2020 06:54
Atemu
Atemu approved these changes Aug 30, 2020
View reviewed changes
Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 96447 1

1 package built:
- firefox-beta-bin-unwrapped

Still works.

@cole-h cole-h changed the title firefox-beta-bin: 80.0b8 -> 81.0b3 firefox-beta-bin: 80.0b8 -> 81.0b4 Sep 1, 2020
@cole-h
Copy link
Member Author

cole-h commented Sep 1, 2020

Updated to 81.0b4.

@vcunat vcunat merged commit 0be331d into NixOS:master Sep 1, 2020
@cole-h cole-h deleted the ff-beta-bin branch September 1, 2020 16:59
@cole-h
Copy link
Member Author

cole-h commented Sep 1, 2020

Thanks, @vcunat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@Atemu Atemu Atemu approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cole-h @vcunat @Atemu