pythonPackages.jupyterlab-git: init at 0.20.0 #96399
Conversation
|
|
||
| doCheck = false; | ||
|
|
There was a problem hiding this comment.
There are no tests included. Please try to checkout from source and check if they have unit tests, and try to run them. Unit tests give a good indication that they package has a high degree of validity and correctness given the python package set.
If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors. Please see pythonImportsCheck documentation for more information.
There was a problem hiding this comment.
They do include checks. However, they didn't run on the NixOS VM I am working on. I'll download from source on my machine and see if the tests work. If they don't, I'll check out the pythonImportsCheck stuff. Thanks!
There was a problem hiding this comment.
I was able to run all of the tests on my machine (ignoring the async ones) but on the NixOS VM it gave weird errors for the test_handlers.py file so I ignored that one. I also added the pythonImportsCheck but I can remove that if you think it is unnecessary.
Motivation for this change
I would like to use this Jupyter Lab extension in a deployment. This PR adds the extension and necessary dependencies only (git and build dependencies). A user would have to install the jupyter and jupyter lab packages separately.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)