Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

satysfi: 0.0.4 → 0.0.5 #96434

Merged
merged 1 commit into from Sep 1, 2020
Merged

satysfi: 0.0.4 → 0.0.5 #96434

merged 1 commit into from Sep 1, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Aug 27, 2020

Motivation for this change

Fixes & improvements: https://github.com/gfngfn/SATySFi/blob/v0.0.5/CHANGELOG.md#005---2020-07-11

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from marsam and mt-caret August 27, 2020 06:24
marsam
marsam approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vbgl vbgl merged commit e92a556 into NixOS:master Sep 1, 2020
@vbgl vbgl deleted the satysfi-0.5.0 branch September 1, 2020 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@mt-caret mt-caret Awaiting requested review from mt-caret

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @marsam