Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode, vscodium: 1.48.1 -> 1.48.2 #96445

Merged
merged 2 commits into from Aug 27, 2020
Merged

vscode, vscodium: 1.48.1 -> 1.48.2 #96445

merged 2 commits into from Aug 27, 2020

Conversation

JesusMtnez
Copy link
Contributor

Motivation for this change

Bump vscode and vscodium to 1.48.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from eadwu and Synthetica9 August 27, 2020 08:07
@Synthetica9
Copy link
Member

Synthetica9 commented Aug 27, 2020 via email

@JesusMtnez
Copy link
Contributor Author

@Synthetica9 I have amended those commits to fit contribution recommendations. Thank you!!

@danieldk danieldk merged commit 3ef5bbc into NixOS:master Aug 27, 2020
@danieldk
Copy link
Contributor

@JesusMtnez Thank you for your first contribution 👍 .

@JesusMtnez JesusMtnez deleted the vscode branch August 27, 2020 13:42
@JesusMtnez
Copy link
Contributor Author

Thank you! Really easy to do, really nice organization. 😄 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@eadwu eadwu Awaiting requested review from eadwu

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JesusMtnez @Synthetica9 @danieldk @samuela @nixos-discourse