Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grub2: use python3 by default #96450

Closed
wants to merge 1 commit into from
Closed

grub2: use python3 by default #96450

wants to merge 1 commit into from

Conversation

Taneb
Copy link
Contributor

@Taneb Taneb commented Aug 27, 2020

It should work fine with either 2 or 3 (I'm pretty sure Arch uses 3, for example), and we should be aiming to move away from python 2 wherever possible

Motivation for this change

I'm trying to see if we can remove Python 2 from the build closure of the minimal installation ISO.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Taneb
grub2: use python3 by default
a583bc7 
It should work fine with either 2 or 3 (I'm pretty sure Arch uses 3, for example), and we should be aiming to move away from python 2 wherever possible
@FRidh
Copy link
Member

FRidh commented Aug 28, 2020

Thanks. Tested $ nix-build nixos/release-combined.nix -A nixos.tests.boot-stage1.x86_64-linux and $ nix-build nixos/release-combined.nix -A nixos.tests.simple.x86_64-linux and pushed 9369f74.

@FRidh FRidh closed this Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Taneb @FRidh