Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 1a94103f1216
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: ca3fa9c32a45
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Aug 22, 2020

  1. runInLinuxVM, test-driver: use -cpu max instead of -cpu host 

    This appears to avoid requiring KVM when it’s not available. This is
what I originally though -cpu host did. Unfortunately not much
documentation available from the QEMU side on this, but this appears
to square with help:

$ qemu-system-x86 -cpu help
...
x86 host                  KVM processor with all supported host features
x86 max                   Enables all features supported by the accelerator in the current host
...

Whether we actually want to support this not clear, since this only
happens when your CPU doesn’t have full KVM support. Some Nix builders
are lying about kvm support though. Things aren’t too slow without it
though.

Fixes #85394

Alternative to #83920
    @matthewbauer
    matthewbauer committed Aug 22, 2020
    Copy the full SHA
    47b56e7 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. Merge pull request #95956 from matthewbauer/qemu-cpu-max 

    runInLinuxVM, test-driver: use -cpu max instead of -cpu host
    @matthewbauer
    matthewbauer committed Aug 26, 2020
    Copy the full SHA
    ca3fa9c View commit details
    Browse the repository at this point in the history