Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainers: add j0hax #96397

Closed
wants to merge 1 commit into from
Closed

maintainers: add j0hax #96397

wants to merge 1 commit into from

Conversation

j0hax
Copy link
Member

@j0hax j0hax commented Aug 26, 2020

Motivation for this change

I would like to maintain some OctoPrint plugins :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gebner
Copy link
Member

gebner commented Aug 29, 2020

Usually people add themselves to the maintainer list in the same PR where they start maintaining a package. So please submit/update/test octoprint plugins!

@jtojnar
Copy link
Contributor

jtojnar commented Aug 30, 2020

Usually people add themselves to the maintainer list in the same PR where they start maintaining a package. So please submit/update/test octoprint plugins!

I would say we allow that for people’s convenience but would not call that a requirement.


What is more problematic is that the name was added to the end, not heeding the instructions at the top of the file:

Please keep the list alphabetically sorted.

Yeah, they are not the only one 🐈

@j0hax
Copy link
Member Author

j0hax commented Aug 30, 2020

Usually people add themselves to the maintainer list in the same PR where they start maintaining a package. So please submit/update/test octoprint plugins!

Will do.

Please keep the list alphabetically sorted.

Missed that, will change with a proper pull request like mentioned above.

@j0hax j0hax closed this Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants