Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnupg: put libexec tools (eg. gpg-preset-passphrase) in PATH #100031

Merged
merged 1 commit into from Oct 25, 2020
Merged

gnupg: put libexec tools (eg. gpg-preset-passphrase) in PATH #100031

merged 1 commit into from Oct 25, 2020

Conversation

ju1m
Copy link
Contributor

@ju1m ju1m commented Oct 8, 2020 •
edited

This is extracted from #93659 as suggested in #93659 (comment)

Motivation for this change

Use gpg-preset-passphrase.

Things done

Symlink $out/libexec/* into $out/bin.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ju1m ju1m mentioned this pull request Oct 8, 2020
Open
26 tasks
@ofborg ofborg bot requested review from fpletz, peti and vrthra October 8, 2020 13:58
@xaverdh
Copy link
Contributor

xaverdh commented Oct 8, 2020

maybe this should go to staging?

@worldofpeace
Copy link
Contributor

Can we please add the motivation directly to the commit message? This is really helpful from looking back at things. Maybe also in the comment. Currently it seems un-intuitive to me why anyone should symlink libexec to bin in gnupg (by just reading the expression)

@worldofpeace
Copy link
Contributor

worldofpeace commented Oct 8, 2020 •
edited

And yes, moving that out of your main PR will make it easier to test 👍

@ju1m ju1m requested a review from stigtsp as a code owner October 8, 2020 14:33
@ju1m ju1m changed the title gnupg: make libexec tools available in PATH gnupg: put libexec tools (eg. gpg-preset-passphrase) in PATH Oct 8, 2020
@ju1m
Copy link
Contributor Author

ju1m commented Oct 8, 2020

@worldofpeace I've changed the commit and PR titles as you requested.

@bqv
Copy link
Contributor

bqv commented Oct 8, 2020

For policy reasons I can easily see why this might want to be repointed at staging, but it passed borg and is very simple to test manually, so it's hard to imagine any vector for it causing problems

@ju1m
Copy link
Contributor Author

ju1m commented Oct 25, 2020

@worldofpeace is there still something to be done to get it merged?

@worldofpeace worldofpeace changed the base branch from master to staging October 25, 2020 21:39
@worldofpeace worldofpeace merged commit 309ce3f into NixOS:staging Oct 25, 2020
@worldofpeace
Copy link
Contributor

thx for pinging 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@peti peti Awaiting requested review from peti

@vrthra vrthra Awaiting requested review from vrthra

@stigtsp stigtsp Awaiting requested review from stigtsp

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ju1m @xaverdh @worldofpeace @bqv