Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starship: 0.45.2 -> 0.46.0 #100043

Merged
merged 1 commit into from Oct 28, 2020
Merged

starship: 0.45.2 -> 0.46.0 #100043

merged 1 commit into from Oct 28, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 8, 2020

Motivation for this change

https://github.com/starship/starship/releases/tag/v0.46.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Oct 9, 2020

Fails with the following test failures for me:

starship> failures:
starship> ---- modules::golang::tests::folder_with_glide_yaml stdout ----
starship> thread 'modules::golang::tests::folder_with_glide_yaml' panicked at 'assertion failed: `(left == right)`
starship>   left: `Some("via \u{1b}[1;36m🐹 v1.12.1\u{1b}[0m ")`,
starship>  right: `None`', src/modules/golang.rs:162:9
starship> note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
starship> failures:
starship>     modules::golang::tests::folder_with_glide_yaml
starship> test result: FAILED. 449 passed; 1 failed; 25 ignored; 0 measured; 10 filtered out
starship> error: test failed, to rerun pass '--lib'
starship> builder for '/nix/store/rqx5mhvr897i1n13rvkx9q29nd8xpk3f-starship-0.46.0.drv' failed with exit code 101

@bbigras
Copy link
Contributor

bbigras commented Oct 9, 2020

@Ma27 on NixOS?

@bbigras
Copy link
Contributor

bbigras commented Oct 9, 2020

Result of nixpkgs-review pr 100043 1

1 package built:
  • starship

davidtwco
davidtwco approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 100043 1

1 package built:
  • starship

@Ma27
Copy link
Member

Ma27 commented Oct 9, 2020

@bbigras yes.

@marsam marsam requested a review from Ma27 October 13, 2020 02:43
@ofborg ofborg bot requested a review from davidtwco October 13, 2020 02:54
@Ma27
Copy link
Member

Ma27 commented Oct 13, 2020

Is there anything wrong with disabling this test?

@bbigras
Copy link
Contributor

bbigras commented Oct 13, 2020

Is there anything wrong with disabling this test?

Maybe we could but could you also run the tests directly on the upstream repo and fill an issue upstream?

git clone https://github.com/starship/starship.git
cd starship
nix-shell -p cargo
cargo test

@marsam
Copy link
Contributor Author

marsam commented Oct 27, 2020

Is there anything wrong with disabling this test?

the test itself looks ordinary, and I'm not sure why it's failing for you.
could you please give the following a try?

--- i/pkgs/tools/misc/starship/default.nix
+++ w/pkgs/tools/misc/starship/default.nix
@@ -33,13 +33,14 @@ rustPlatform.buildRustPackage rec {
 
   cargoSha256 = "1smz7084ppz79p8migpy0cqp6azf7sixv9ga65l2f3zfna7kbk78";
 
+  cargoParallelTestThreads = false;
+
   checkFlags = [
     "--skip=directory_in_home"
     "--skip=home_directory"
     "--skip=directory_in_root"
     "--skip=truncation_symbol_not_truncated_home"
     "--skip=truncation_symbol_truncated_home"
-    "--skip=folder_with_glide_yaml"
     "--skip=shows_multiple_tfms"
     "--skip=shows_pinned_in_project_below_root_with_global_json"
   ];

@teto
Copy link
Member

teto commented Oct 27, 2020

dunno if that helps but current release is https://github.com/starship/starship/tree/v0.46.2

@marsam marsam merged commit b69f140 into NixOS:master Oct 28, 2020
@marsam marsam deleted the update-starship branch October 28, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frostman Frostman Awaiting requested review from Frostman

@bbigras bbigras Awaiting requested review from bbigras

@Ma27 Ma27 Awaiting requested review from Ma27

@davidtwco davidtwco Awaiting requested review from davidtwco

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marsam @Ma27 @bbigras @teto @davidtwco