-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fourier #2738
Fourier #2738
Conversation
numerics/poisson_series.hpp
Outdated
// apodization function, and |FourierTransform| should be called on the | ||
// product. | ||
// |*this| must outlive the resulting function. | ||
std::function<Complexification<Value>(AngularFrequency const&)> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd favour giving a name to this type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this file should include functional
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd favour giving a name to this type.
meh.
Also, this file should include
functional
.
Done.
0 * Radian / Second, | ||
2 * Radian / Second, | ||
std::greater<>{}), | ||
IsNear(1.9999999_⑴ * Radian / Second)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
@@ -417,34 +470,29 @@ TEST_F(PiecewisePoissonSeriesTest, ActionMultiorigin) { | |||
auto const s2 = pp_ + p; | |||
EXPECT_THAT(s1(t0_ + 0.5 * Second), | |||
AlmostEquals((10 - 3 * Sqrt(2)) / 4, 1)); | |||
EXPECT_THAT(s1(t0_ + 1.5 * Second), | |||
AlmostEquals((6 + Sqrt(2)) / 4, 0)); | |||
EXPECT_THAT(s1(t0_ + 1.5 * Second), AlmostEquals((6 + Sqrt(2)) / 4, 0)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the changes to lines 473-483.
Add a continuous Fourier transform on piecewise Poisson series, for use in Chapront’s frequency search to refine the output of the DFT.
Another flying buttress for #2400.
The autoformatter went wild again; kept some of what it did where some code was egregiously poorly formatted (
4* Sqrt(2)
???).