Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fourier #2738

Merged
merged 7 commits into from
Sep 28, 2020
Merged

Fourier #2738

merged 7 commits into from
Sep 28, 2020

Conversation

eggrobin
Copy link
Member

Add a continuous Fourier transform on piecewise Poisson series, for use in Chapront’s frequency search to refine the output of the DFT.

Another flying buttress for #2400.

The autoformatter went wild again; kept some of what it did where some code was egregiously poorly formatted (4* Sqrt(2)???).

// Gauss-Legendre quadrature on each subinterval, where the number of points
// is chosen assuming that the periods of periodic terms are all large
// compared to the subintervals.
// If apodization is desired, the |*this| should be multiplied by an
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "the", it reads odd.

Sorry, something went wrong.

// apodization function, and |FourierTransform| should be called on the
// product.
// |*this| must outlive the resulting function.
std::function<Complexification<Value>(AngularFrequency const&)>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd favour giving a name to this type.

Sorry, something went wrong.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this file should include functional.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd favour giving a name to this type.

meh.

Also, this file should include functional.

Done.

0 * Radian / Second,
2 * Radian / Second,
std::greater<>{}),
IsNear(1.9999999_⑴ * Radian / Second));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@pleroy pleroy added the LGTM label Sep 28, 2020
@eggrobin eggrobin merged commit 1832ab1 into mockingbirdnest:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants