bazel-remote: 1.0.0 -> 2.0.1 #98983

uri-canva · 2020-09-28T03:20:56Z

Motivation for this change

Upgrade bazel-remote

Things done

pkgs/development/tools/build-managers/bazel/bazel-remote/default.nix

Profpatsch · 2020-10-08T16:57:06Z

The linux build has a wrong hash:

hash mismatch in fixed-output derivation '/nix/store/xf6vs1qd0m2yklhi4l7085y1xkx9zjzr-bazel-remote-1.2.0-deps.tar.gz':
  wanted: sha256:1b6252cz26qwc5nvd34ld3fr908bz55w136x9y27yx39z5ynnbb8
  got:    sha256:0063gdrjirh7jjrnj3sannwf5134sq40l3qk3ffa29l0ka5m5qmj
cannot build derivation '/nix/store/0w717cm8cd1s2fdp28z0lkpgbarc2ryv-bazel-remote-1.2.0.drv': 1 dependencies couldn't be built

uri-canva · 2020-10-08T21:16:36Z

Yeah there must be some non-deterministic output in the dependencies. I'll have to diff them.

Profpatsch · 2020-10-09T12:21:53Z

For now you can use the linux hash that ofborg gave us and pray that it works :)

…

On Thu, Oct 8, 2020 at 11:16 PM Uri Baghin ***@***.***> wrote: Yeah there must be some non-deterministic output in the dependencies. I'll have to diff them. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#98983 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYB5ZXD3NGLYUFNLNVBCPLSJYT4NANCNFSM4R37GNZQ> .

teto · 2020-10-22T13:58:01Z

I get a hash error too locally sha256-TACUGccNKVF6EyxSjNA4NDnR6BHOiR7OHughClW91Oo= .

teto · 2020-10-22T20:08:24Z

sry to hijack the thread a bit but I've tried to upgrade to 1.2.0 in an overlay

  bazel-remote = super.bazel-remote.overrideAttrs(oa: rec {
    version = "1.2.0";
    name = "bazel-remote-1.2.0";
    # oa
    nativeBuildInputs = oa.nativeBuildInputs ++ [ self.python ];
    src = self.fetchFromGitHub {
      owner = "buchgr";
      repo = "bazel-remote";
      rev = "v${version}";
      sha256 = "1ycffgm5p4xx7dnx2k1bfalwn0s1468849601s4x7fbwmnyp8sjz";
    };
    # bazel deps are a derivation themselves
    deps = oa.deps.overrideAttrs(depsOa: {
      name = "${name}-deps.tar.gz";

      nativeBuildInputs = depsOa.nativeBuildInputs ++ [ self.python ];
      outputHash =   "sha256-cY9WyrnvGhY0wphC3v6JUvFf7BpnMgJ6dy5HOsCq7tQ=";
    });
    # patches = oa.patches ++ [ ./bazel-remote/force-download.patch ];
  });

but when running it I get

^M^MLoading: 0 packages loaded
    Fetching @pip_deps; fetching 7s
^M^MLoading: 0 packages loaded
    Fetching @pip_deps; fetching 8s
^M^MINFO: Repository pip_deps instantiated at:
  no stack (--record_rule_instantiation_callstack not enabled)
Repository rule pip_import defined at:
  /build/output/external/rules_python/python/pip.bzl:42:29: in <toplevel>
Loading: 0 packages loaded
    Fetching @pip_deps; fetching 8s
^M^MERROR: An error occurred during the fetch of repository 'pip_deps':
   pip_import failed: Collecting six==1.11.0 (from -r /build/output/external/io_bazel_rules_docker/repositories/requirements-pip.txt (line 2))
 (  Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x7ffff698d2d0>: Failed to establish a new connection: [Errno -2] Name or service not known',)': /simple/six/
  Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x7ffff698d610>: Failed to establish a new connection: [Errno -2] Name or service not known',)': /simple/six/
  Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x7ffff698d790>: Failed to establish a new connection: [Errno -2] Name or service not known',)': /simple/six/
  Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x7ffff698d910>: Failed to establish a new connection: [Errno -2] Name or service not known',)': /simple/six/
  Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x7ffff698da90>: Failed to establish a new connection: [Errno -2] Name or service not known',)': /simple/six/
  Could not find a version that satisfies the requirement six==1.11.0 (from -r /build/output/external/io_bazel_rules_docker/repositories/requirements-pip.txt (line 2)) (from versions: )
No matching distribution found for six==1.11.0 (from -r /build/output/external/io_bazel_rules_docker/repositories/requirements-pip.txt (line 2))

and I have no idea why. I tried callPackage on your default.nix and the build went fine. My overlay uses the same buildBazelPackage implementation and all I dont know what I am missing.

Feel free to ignore the question though, it's just that I dont get it :/

teto · 2021-03-31T16:33:40Z

Nevermind my previous message, it worked. still the hash seems non deterministic. Maybe it's fixed in the 1.3.1 version ?

uri-canva · 2021-05-06T12:31:20Z

It went up a whole major version, so I'll start again from there: https://github.com/buchgr/bazel-remote/releases

uri-canva · 2021-05-07T02:54:28Z

Switch this to build using buildGoModule rather than buildBazelPackage. The instructions in the repo say to use bazel, but looking at the bazel files the only difference is that main.gitCommit isn't set, which we probably don't want to set anyway, since it doesn't really correspond to what upstream would consider a regular build at that commit.

Building using buildBazelPackage seems to be hard because of bazelbuild/rules_go#2377, which will require patching our own nix based go toolchain into the build.

uri-canva · 2021-05-13T05:45:36Z

ping @kalbasit @Profpatsch

Profpatsch · 2021-05-14T15:52:53Z

I’m not doing much with bazel anymore, but if it builds & works LGTM

teto · 2021-05-14T16:53:45Z

it compiles and seems to work. Seems to save results in a new format too: in a cas2 subfolder.

SuperSandro2000 · 2021-05-17T17:20:22Z

pkgs/development/tools/build-managers/bazel/bazel-remote/default.nix

-      install -Dm755 bazel-bin/*_pure_stripped/bazel-remote $out/bin/bazel-remote
-    '';
-  };
+  doCheck = false;

  meta = with lib; {
    homepage = "https://github.com/buchgr/bazel-remote";
    description = "A remote HTTP/1.1 cache for Bazel";
    license = licenses.asl20;
    maintainers = [ maintainers.uri-canva ];
    platforms = platforms.darwin ++ platforms.linux;


Suggested change

platforms = platforms.darwin ++ platforms.linux;

set by buildGoModule.

SuperSandro2000 · 2021-05-17T17:20:29Z

pkgs/development/tools/build-managers/bazel/bazel-remote/default.nix

-      install -Dm755 bazel-bin/*_pure_stripped/bazel-remote $out/bin/bazel-remote
-    '';
-  };
+  doCheck = false;


Why are tests disabled?

Presumably cause they don’t work? I wouldn’t give too much thought about this.

uri-canva requested a review from Profpatsch as a code owner September 28, 2020 03:20

uri-canva commented Sep 28, 2020

View reviewed changes

ofborg bot added 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 28, 2020

Profpatsch approved these changes Oct 8, 2020

View reviewed changes

pkgs/development/tools/build-managers/bazel/bazel-remote/default.nix Outdated Show resolved Hide resolved

SuperSandro2000 marked this pull request as draft November 27, 2020 01:32

SuperSandro2000 added the 2.status: merge conflict label Jan 18, 2021

bazel-remote: 1.0.0 -> 2.0.1

71f908c

uri-canva force-pushed the bazel-remote branch from 92a951a to 71f908c Compare May 7, 2021 02:49

ofborg bot removed the 2.status: merge conflict label May 7, 2021

uri-canva marked this pull request as ready for review May 7, 2021 02:54

uri-canva requested review from Profpatsch and teto May 7, 2021 02:55

uri-canva changed the title ~~bazel-remote: 1.0.0 -> 1.2.0~~ bazel-remote: 1.0.0 -> 2.0.1 May 7, 2021

ofborg bot requested a review from kalbasit May 7, 2021 02:58

uri-canva requested a review from mboes May 15, 2021 00:26

uri-canva requested a review from SuperSandro2000 May 15, 2021 00:26

SuperSandro2000 reviewed May 17, 2021

View reviewed changes

Profpatsch merged commit a975c80 into NixOS:master May 17, 2021

uri-canva deleted the bazel-remote branch June 29, 2023 01:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bazel-remote: 1.0.0 -> 2.0.1 #98983

bazel-remote: 1.0.0 -> 2.0.1 #98983

uri-canva commented Sep 28, 2020 •

edited

Profpatsch commented Oct 8, 2020

uri-canva commented Oct 8, 2020

Profpatsch commented Oct 9, 2020 via email

teto commented Oct 22, 2020

teto commented Oct 22, 2020

teto commented Mar 31, 2021

uri-canva commented May 6, 2021

uri-canva commented May 7, 2021

uri-canva commented May 13, 2021

Profpatsch commented May 14, 2021

teto commented May 14, 2021

SuperSandro2000 May 17, 2021

SuperSandro2000 May 17, 2021

Profpatsch May 17, 2021

bazel-remote: 1.0.0 -> 2.0.1 #98983

bazel-remote: 1.0.0 -> 2.0.1 #98983

Conversation

uri-canva commented Sep 28, 2020 • edited

Motivation for this change

Things done

Profpatsch commented Oct 8, 2020

uri-canva commented Oct 8, 2020

Profpatsch commented Oct 9, 2020 via email

teto commented Oct 22, 2020

teto commented Oct 22, 2020

teto commented Mar 31, 2021

uri-canva commented May 6, 2021

uri-canva commented May 7, 2021

uri-canva commented May 13, 2021

Profpatsch commented May 14, 2021

teto commented May 14, 2021

SuperSandro2000 May 17, 2021

Choose a reason for hiding this comment

SuperSandro2000 May 17, 2021

Choose a reason for hiding this comment

Profpatsch May 17, 2021

Choose a reason for hiding this comment

uri-canva commented Sep 28, 2020 •

edited