Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling was a bit broken for string-editor #18

Merged
merged 4 commits into from Sep 28, 2020

Conversation

TrueBrain
Copy link
Member

No description provided.

"message_class" contains the string "info" / "success" / "warning" / "error",
where "class" contains the bootstrap CSS name.
This caused template failures, meaning people could not see what
they did wrong. How the field is called is now abstracted away
by using kwargs instead of a dict.
This simply happens, as users are being users. It is not a log
message that is useful for anyone, except when developing. In that
case you get this nice page telling you the project doesn't exist.
@TrueBrain TrueBrain merged commit 0e74072 into OpenTTD:master Sep 28, 2020
@TrueBrain TrueBrain deleted the fix_messages branch September 28, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants