sony-pioneer: init #205
Merged
sony-pioneer: init #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same SoC, same kernel version, most likely will work better that way
Otherwise untouched from OEM config.
We do not add LOCALVERSION to the kernels.
(As with xiaomi-lavender)
(As with xiaomi-lavender)
This one is important as, contrary to what the name sounds like, it builds the full device tree with the kernel, rather than rely on on-device overlays.
It is counter-productive for non-android systems.
(As with xiaomi-lavender)
…eOS defconfig This one comes from an artifact of starting up with the **OEM's** configuration, but actually using the LineageOS tree. LineageOS adds many alterations that may cause incompatibilities.
This is not strictly needed, but rather quite helpful to get network access until we can get WiFi working.
samueldr
force-pushed
the
device/sony-pioneer/port
branch
from
3d5b04f
to
5c68fac
Compare
samueldr
force-pushed
the
device/sony-pioneer/port
branch
from
5c68fac
to
78647e9
Compare
|
With this PR we're creating a kind of precedent, which I'm not 100% sure we'll keep using. We are now shipping unused files with information about the OEM images, as extracted by autoport. While this is not great because it's unused, it's actually not bad as it allows documenting some aspects of the device in a generic manner that is helpful for reviewers. By adding the data that autoport used to the repository, we can add fixes to autoport as needed and better understand why things were ported "that way". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a demo PR (that will be merged) that shows all the work done to port a device from the autoport project.
It took 50 minutes moment I copied the config to the repo, to the moment I booted to the demo rootfs. This is a new record for myself.
The important bit, for future porter-users, are for the kernel.
I have taken another SDM660 device's kernel builder derivation (xiaomi-lavender) and copied it outright with patches (as the patches were known non-specific).
And finally the changes to the kernel configuration. I have basically used
nvim -don the default config and another SDM660 device to figure out what was missing.Note that the USB vid/pid have been figured out by looking through the files extracted from a system image. There is no failsafe way to get them, other than running the OEM's system image and looking at what the device advertises as.