Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.cirq: 0.8.2 -> 0.9.1 #100000

Merged
merged 1 commit into from Oct 8, 2020
Merged

python3Packages.cirq: 0.8.2 -> 0.9.1 #100000

merged 1 commit into from Oct 8, 2020

Conversation

drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Oct 8, 2020 •
edited

Motivation for this change

New minor version (feature update).
https://github.com/quantumlib/Cirq/releases/tag/v0.9.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

congratulations! you're the 100,000th issue/PR :)

jonringer
jonringer approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 100000 1

2 packages built:
  • python37Packages.cirq
  • python38Packages.cirq

@jonringer jonringer merged commit a2e6852 into NixOS:master Oct 8, 2020
@drewrisinger drewrisinger deleted the dr-pr-cirq branch October 8, 2020 05:55
@makefu
Copy link
Contributor

makefu commented Oct 8, 2020 •
edited

Just as expected from nixpkgs, #100000 is a bumped package instead of a 100.000 GET!
Lets make nixpkgs the first repo which hits #1000000 🚀

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/200-000-issues-pull-requests-in-nixpkgs/23070/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@drewrisinger @jonringer @makefu @nixos-discourse