Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gimp: 2.10.20 -> 2.10.22 #99990

Merged
merged 2 commits into from Oct 8, 2020
Merged

gimp: 2.10.20 -> 2.10.22 #99990

merged 2 commits into from Oct 8, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Oct 8, 2020

Motivation for this change

https://www.gimp.org/news/2020/10/07/gimp-2-10-22-released/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jtojnar October 8, 2020 00:43
@mweinelt
Copy link
Member

mweinelt commented Oct 8, 2020

Result of nixpkgs-review pr 99990 1

5 packages marked as broken and skipped:
  • gimpPlugins.exposureBlend
  • gimpPlugins.focusblur
  • gimpPlugins.texturize
  • gimpPlugins.ufraw
  • ufraw
10 packages built:
  • gimp
  • gimp-with-plugins
  • gimpPlugins.fourier
  • gimpPlugins.gap
  • gimpPlugins.gimplensfun
  • gimpPlugins.gmic
  • gimpPlugins.lightning
  • gimpPlugins.lqrPlugin
  • gimpPlugins.resynthesizer
  • gimpPlugins.waveletSharpen

jtojnar
jtojnar reviewed Oct 8, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is to be noted that, even though GIMP minimum requirement is babl 0.1.78, we advise to build against the latest version if possible, i.e. babl 0.1.82. This last version handles more complex parametric TRCs for ICCv4, which means that without these changes, your color profile conversion may be wrong in case you use a profile with these parameters.

@ofborg ofborg bot requested a review from jtojnar October 8, 2020 16:00
@jtojnar
Copy link
Contributor

jtojnar commented Oct 8, 2020

Babl changes: https://gitlab.gnome.org/GNOME/babl/-/blob/BABL_0_1_82/NEWS#L6-9

@jtojnar jtojnar merged commit 0790b3e into NixOS:master Oct 8, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Oct 8, 2020

Thanks.

@ajs124 ajs124 deleted the upd/gimp branch October 8, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @mweinelt @jtojnar