Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find-cursor: init at 1.6 #100002

Merged
merged 1 commit into from Nov 5, 2020
Merged

find-cursor: init at 1.6 #100002

merged 1 commit into from Nov 5, 2020

Conversation

yanganto
Copy link
Member

@yanganto yanganto commented Oct 8, 2020

Motivation for this change

This X11 tool helps me find the cursor when using 4 screens.
It is good and usable, so I package this on NixOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

IvarWithoutBones
IvarWithoutBones requested changes Oct 8, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits, otherwise LGTM :)

1 more suggestion: You could run nixpkgs-fmt on this, which would make the formatting consistent with the rest of the codebase.

Also, commit message should be the following: find-cursor: init at 1.6

pkgs/tools/X11/find-cursor/default.nix Outdated Show resolved Hide resolved
pkgs/tools/X11/find-cursor/man.patch Outdated Show resolved Hide resolved
pkgs/tools/X11/find-cursor/default.nix Outdated Show resolved Hide resolved
@yanganto
Copy link
Member Author

yanganto commented Oct 8, 2020

@IvarWithoutBones Very thanks for reviewing this.

IvarWithoutBones
IvarWithoutBones requested changes Oct 8, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more nits, otherwise LGTM 👍

Formatting is still a bit weird, could you run nixpkgs-fmt on the derivation? (nix run nixpkgs.nixpkgs-fmt -c nixpkgs-fmt pkgs/tools/X11/find-cursor/default.nix

Also, commits should be squashed.

pkgs/tools/X11/find-cursor/default.nix Outdated Show resolved Hide resolved
pkgs/tools/X11/find-cursor/default.nix Outdated Show resolved Hide resolved
@yanganto @IvarWithoutBones
find-cursor: init at 1.6
7e51cfa 
Co-authored-by: Ivar <41924494+IvarWithoutBones@users.noreply.github.com>
@roberth
Copy link
Member

roberth commented Nov 5, 2020

Thank you @yanganto!

@roberth roberth merged commit 24f36f8 into NixOS:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvarWithoutBones IvarWithoutBones IvarWithoutBones requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yanganto @roberth @IvarWithoutBones