New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
home-assistant: 0.115.6 -> 0.116.2; python3Packages.voluptuous: 0.11.7 -> 0.12.0; pythonPackages.yeelight: 0.5.3 -> 0.5.4 #99986
Conversation
6ae44c0
to
3550940
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
if you don't want to rewrite the test logic, then thats all good :)
https://github.com/NixOS/nixpkgs/pull/99986
27 packages built:
appdaemon elasticsearch-curator esphome home-assistant python27Packages.voluptuous python37Packages.async-upnp-client python37Packages.bellows python37Packages.pyhs100 python37Packages.voluptuous python37Packages.voluptuous-serialize python37Packages.zha-quirks python37Packages.zigpy python37Packages.zigpy-cc python37Packages.zigpy-deconz python37Packages.zigpy-xbee python37Packages.zigpy-zigate python38Packages.async-upnp-client python38Packages.bellows python38Packages.pyhs100 python38Packages.voluptuous python38Packages.voluptuous-serialize python38Packages.zha-quirks python38Packages.zigpy python38Packages.zigpy-cc python38Packages.zigpy-deconz python38Packages.zigpy-xbee python38Packages.zigpy-zigate
Enable tests by running nosetests during checkPhase.
Enables testing in parallel. This cuts down the test phase from over five to under one minute on my 6C/12T processor. Sadly while the upstream runs their tests using `-n auto` this isn't working for us in all cases. I currently assume they use low concurrency in their CI, which is not triggering these issues..
And https://github.com/home-assistant/core/releases/tag/0.116.2. I'll merge this after @GrahamcOfBorg confirms all well, else we're gonna stack more updates. They're coming fast these days. |
Use pytestCheckhook for testing.
Result of 30 packages built:
|
Motivation for this change
New upstream release. Bumped voluptuous, since they required a newer version released two weeks ago.
Also enabled parallel testing using xdist, which cuts down the testPhase by a large margin.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)