Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] pythonPackages.pyotp: fix tests #100025

Merged
merged 1 commit into from Oct 11, 2020
Merged

[20.09] pythonPackages.pyotp: fix tests #100025

merged 1 commit into from Oct 11, 2020

Conversation

IvarWithoutBones
Copy link
Member

(cherry picked from commit ae23d0bf634d460be9e75702f369a08c1c2e64ba)

ZHF: #97479

PR to master: #100023

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@IvarWithoutBones
pythonPackages.pyotp: fix tests
b7a20d0 
(cherry picked from commit ae23d0bf634d460be9e75702f369a08c1c2e64ba)
@IvarWithoutBones IvarWithoutBones changed the title pythonPackages.pyotp: fix tests [20.09] pythonPackages.pyotp: fix tests Oct 8, 2020
@ofborg ofborg bot requested a review from dotlambda October 8, 2020 10:36
@risicle
Copy link
Contributor

risicle commented Oct 8, 2020

I generally wouldn't open a backport PR until after the original is merged as someone may choose to do a rebase-merge, which would mean your original commit id wouldn't make it in.

jonringer
jonringer approved these changes Oct 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 100025 1

4 packages built:
  • home-assistant
  • python27Packages.pyotp
  • python37Packages.pyotp
  • python38Packages.pyotp

@jonringer jonringer merged commit 5ed3b07 into NixOS:release-20.09 Oct 11, 2020
@risicle
Copy link
Contributor

risicle commented Oct 11, 2020

This hasn't been merged to master yet.

@IvarWithoutBones IvarWithoutBones deleted the pyotp-fix-backport branch October 23, 2020 02:23
@IvarWithoutBones IvarWithoutBones mentioned this pull request Oct 23, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IvarWithoutBones @risicle @jonringer