Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sudo: 1.8.31p1 -> 1.9.3p1 + adding myself as maintainer #100024

Merged
merged 3 commits into from Oct 10, 2020
Merged

sudo: 1.8.31p1 -> 1.9.3p1 + adding myself as maintainer #100024

merged 3 commits into from Oct 10, 2020

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Oct 8, 2020 •
edited

Motivation for this change

sudo in nixpkgs is currently lagging several versions behind, and it seems to be solely due to maintainer bandwidth (no reply on the last two pull requests bumping the package, #93100 and #88768). We're currently stuck on a release from 5 months ago, which isn't ideal for such a core package.

This PR bumps to the newest release, and adds myself as a maintainer for sudo so I can help with keeping this up to date in the future.

Closes #93100
Closes #88768

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edolstra October 8, 2020 10:34
@samueldr
Copy link
Member

Thanks for the upgrade!

@samueldr samueldr merged commit 8d3a7d9 into NixOS:master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 ajs124 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delroth @samueldr @ajs124