Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tox-node: 0.0.8 -> 0.1.0 #99979

Merged
merged 1 commit into from Oct 8, 2020
Merged

tox-node: 0.0.8 -> 0.1.0 #99979

merged 1 commit into from Oct 8, 2020

Conversation

suhr
Copy link
Contributor

@suhr suhr commented Oct 7, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

drewrisinger
drewrisinger suggested changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM minus gpl3 license: looks like should be gpl3 only (there's no "or later" text in the license provided on GitHub
  • Commits LGTM
  • Builds via nix-review
 https://github.com/NixOS/nixpkgs/pull/99979
1 package built:
tox-node

@suhr
Copy link
Contributor Author

suhr commented Oct 8, 2020

Cargo.toml says this is gpl3Plus: https://github.com/tox-rs/tox-node/blob/master/Cargo.toml#L15

drewrisinger
drewrisinger approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct. I was searching for the wrong text string in the GPL 3 license. Switching to approved.

@marsam marsam merged commit f174a84 into NixOS:master Oct 8, 2020
@suhr suhr deleted the tox branch October 9, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@suhr @drewrisinger @marsam