Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/ Added nb #100019

Closed
wants to merge 3 commits into from
Closed

feat/ Added nb #100019

wants to merge 3 commits into from

Conversation

CreativeCactus
Copy link

Motivation for this change

Adding nb to nixpkgs, since I already wrote a derivation.

Very small change.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

fadenb
fadenb reviewed Oct 8, 2020
View reviewed changes
Copy link
Contributor

@fadenb fadenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the two inline comments LGTM (none of them seems like a real issue)

pkgs/tools/misc/nb/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/nb/default.nix
Comment on lines +9 to +13
src = fetchgit {
url = "https://github.com/xwmx/nb.git";
rev = version;
sha256 = "LXgLzO+rPCalkWBF79U2Y8r+wtTfSMMuHRYlT/wKd3g=";
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe currently fetchFromGitHub is preferred over `fetchgit if no submodules are needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, where should I look to find conventions like this?
I don't have time to fix this up right now, but probably will this week (otherwise updates welcome).

SuperSandro2000
SuperSandro2000 requested changes Nov 27, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use pname and version and replace let in with rec. Also update the PR title and commit title to fit the contributing guide.

@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@Artturin
Copy link
Member

Artturin commented Feb 2, 2023

nb was added in 44414b4

@Artturin Artturin closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@fadenb fadenb fadenb approved these changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@CreativeCactus @Artturin @fadenb @SuperSandro2000 @Janik-Haag