Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.google_cloud_asset: fix build, 2.0.0 -> 2.1.0 #100009

Merged
merged 4 commits into from Oct 14, 2020
Merged

python3Packages.google_cloud_asset: fix build, 2.0.0 -> 2.1.0 #100009

merged 4 commits into from Oct 14, 2020

Conversation

austinbutler
Copy link
Member

Motivation for this change

Build was missing dependencies. Will backport for 20.09.

https://hydra.nixos.org/build/127625743

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@austinbutler austinbutler changed the title Google cloud asset fix python3Packages.google_cloud_asset: fix build Oct 8, 2020
@ofborg ofborg bot requested a review from costrouc October 8, 2020 06:36
@austinbutler austinbutler changed the title python3Packages.google_cloud_asset: fix build python3Packages.google_cloud_asset: fix build, 2.0.0 -> 2.1.0 Oct 13, 2020
@ofborg ofborg bot requested a review from ruuda October 13, 2020 04:12
ruuda
ruuda approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@ruuda ruuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the libcst tests! Those changes look good to me.

I glossed over the other changes as well and those look good to me too, but I am not an expert in Python packaging.

jonringer
jonringer approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 100009 1

10 packages built:
  • python37Packages.google-cloud-access-context-manager
  • python37Packages.google-cloud-org-policy
  • python37Packages.google_cloud_asset
  • python37Packages.google_cloud_dataproc
  • python37Packages.libcst
  • python38Packages.google-cloud-access-context-manager
  • python38Packages.google-cloud-org-policy
  • python38Packages.google_cloud_asset
  • python38Packages.google_cloud_dataproc
  • python38Packages.libcst

@jonringer jonringer merged commit 326a5f7 into NixOS:master Oct 14, 2020
@austinbutler austinbutler deleted the google-cloud-asset-fix branch October 14, 2020 16:32
@austinbutler austinbutler mentioned this pull request Oct 15, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruuda ruuda ruuda approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@austinbutler @ruuda @jonringer