New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel_1: fix build on darwin #100012
bazel_1: fix build on darwin #100012
Conversation
@risicle You are an avid contributor who has a Mac machine. Could you try to build this and see if you get the same error? |
I haven’t tried it out, but the changes look benign for non-MacOS. The failing test must be unrelated. |
WFM macos 10.14. |
@risicle Without any errors? |
No errors. |
Nice, I'll guess this is then ready to merge too😃 |
Your commit message still has all the
stuff in it. |
Use clang_8 instead of clang_7 on darwin to fix thread_local storage error.
5360bc9
to
f7aafe6
Compare
@risicle Ah yes I forgot about that. Thanks for reminding me. I rebased and edited the commit message. |
This seems sensible. I think normally people would try and keep the |
Motivation for this change
ZHF: #97479
cc: @NixOS/nixos-release-managers
Uses clang_8 instead of clang_7 on darwin to fix thread_local error.
The build runs through successfully but bazel fails to start the server:
Could anybody with more knowledge about
bazel
jump in and help me finish this pr?Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)