Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrow-cpp: 1.0.0 -> 1.0.1 #99994

Merged
merged 1 commit into from Oct 9, 2020
Merged

arrow-cpp: 1.0.0 -> 1.0.1 #99994

merged 1 commit into from Oct 9, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Oct 8, 2020 •
edited

Motivation for this change

A bugfix release: https://github.com/apache/arrow/blob/apache-arrow-1.0.1/CHANGELOG.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member Author

veprbl commented Oct 8, 2020

@GrahamcOfBorg build arrow-cpp
@GrahamcOfBorg build python37Packages.pyarrow
@GrahamcOfBorg build python38Packages.pyarrow

@ofborg ofborg bot requested a review from tobim October 8, 2020 03:06
jonringer
jonringer approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/99994
3 packages failed to build:
python37Packages.google_cloud_bigquery python37Packages.ibis-framework python38Packages.google_cloud_bigquery

7 packages built:
arrow-cpp python37Packages.datasets python37Packages.intake python37Packages.pyarrow python38Packages.datasets python38Packages.intake python38Packages.pyarrow

@jonringer jonringer merged commit 6b74dfe into NixOS:master Oct 9, 2020
@veprbl veprbl mentioned this pull request Oct 9, 2020
Merged
10 tasks
@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label Oct 9, 2020
@veprbl veprbl deleted the pr/arrow_cpp_1_0_1 branch December 1, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@tobim tobim Awaiting requested review from tobim

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @jonringer