Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythia: 8.244 -> 8.303 #99993

Merged
merged 2 commits into from Oct 9, 2020
Merged

pythia: 8.244 -> 8.303 #99993

merged 2 commits into from Oct 9, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Oct 8, 2020 •
edited

Motivation for this change

Bump pythia version to the latest version

Closes: #90120

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

drewrisinger
drewrisinger reviewed Oct 8, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM minus comment on hepmc version locking.
  • Commits LGTM
  • Builds via nix-review on x86_64-linux:
https://github.com/NixOS/nixpkgs/pull/99993
2 packages built:
pythia sacrifice

pkgs/top-level/all-packages.nix
@@ -26755,7 +26755,9 @@ in

nlojet = callPackage ../development/libraries/physics/nlojet { };

pythia = callPackage ../development/libraries/physics/pythia { };
pythia = callPackage ../development/libraries/physics/pythia {
hepmc = hepmc2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you lock hepmc = hepmc2 if pythia seems to support hepmc3 (i.e. has configure flags for hepmc3)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not had time to test hepmc3 yet. I am using the sacrifice interface which only works with hepmc2. There is no real rush to switch now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment to that effect about why the version is restricted

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not restricted, just that the default is unchanged. pythia.override { hepmc=hepmc3; } will compile fine.

@veprbl veprbl merged commit 5540128 into NixOS:master Oct 9, 2020
@veprbl veprbl deleted the pr/pythia_8_303 branch October 9, 2020 19:16
@veprbl veprbl restored the pr/pythia_8_303 branch December 1, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @drewrisinger